feat: use drag.* events to set drop target styles
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsgoulart
reviewed
Aug 4, 2023
pinussilvestrus
force-pushed
the
53-replace-dragula-behavior
branch
from
eeac9c9
to
fccd53c
Compare
pinussilvestrus
force-pushed
the
53-replace-dragula-behavior
branch
from
fccd53c
to
3e23960
Compare
|
Ready for review again. |
vsgoulart
approved these changes
Aug 8, 2023
|
@slolatte @esraagamal6 this is ready for test now 👍 https://53-replace-dragula-behavior--camunda-form-playground.netlify.app/
|
|
@pinussilvestrus Acceptance testing passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
This is to make this behavior agnostic from the dragging library we use under the hood but use our own internal events. The styles of the border is unchanged.
Demo: https://53-replace-dragula-behavior--camunda-form-playground.netlify.app/